[PNE-7661] Deprecate most top-level design spaces. #1006
Merged
+108
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoto-moniz
force-pushed
the
feature/pne-7661-deprecate-old-ds-types
branch
from
bd1c75e to
539cf45
Compare
kroenlein
previously approved these changes
Jan 5, 2026
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
One question,all looks good.
| Resources in this collection. | ||
| """ | ||
| for element in collection: |
Collaborator
There was a problem hiding this comment.
Why reimplement the method instead of just wrapping the parent method and running the return through the verification?
Collaborator
Author
There was a problem hiding this comment.
Great question. That thought occurred to me, but I can't recall why I went this way.
As a simplification for the platform, all design spaces should be either a ProductDesignSpace or HierarchicalDesignSpace. The other types (namely, DataSourceDesignSpace and FormulationDesignSpace) should be subspaces of them. This is the only structure supported by the UI, so it will improve their experience of the platform, too. Additionally, EnumeratedDesignSpace is obsolete, and should be replaced by a DataSourceDesign space within a ProductDesignSpace. Note that we also emit a warning on retrieval. That's because when we go to v4.0, we will stop supporting such design spaces at all. This gives users a chance to update their design spaces as necessary, and ensures they will not be surprised when the type of design space they retrieve changes.
anoto-moniz
force-pushed
the
feature/pne-7661-deprecate-old-ds-types
branch
from
539cf45 to
7882715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a simplification for the platform, all design spaces should be either a ProductDesignSpace or HierarchicalDesignSpace. The other types (namely, DataSourceDesignSpace and FormulationDesignSpace) should be subspaces of them. This is the only structure supported by the UI, so it will improve their experience of the platform, too.
Additionally, EnumeratedDesignSpace is obsolete, and should be replaced by a DataSourceDesign space within a ProductDesignSpace.
Note that we also emit a warning on retrieval. That's because when we go to v4.0, we will stop supporting such design spaces at all. This gives users a chance to update their design spaces as necessary, and ensures they will not be surprised when the type of design space they retrieve changes.
PR Type:
Adherence to team decisions